1162005 - Pocket panel doesn't autofit size (width/height) to localized content (scrollbars, content partially hidden)

Status: RESOLVED DUPLICATE of bug 1163360

(Firefox :: Pocket, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: screenshot of issue

Firefox Nightly, self-compiled and the strings in dictionary.js replaced with the German ones (bug 1161841). Windows 8.1

The Pocket panel doesn't autofit if localized content gets used which can be longer than English one, e.g. scrollbars are shown and content partially hidden (in the screenshot: Logging in with already existing account).

Or in other words:

jaws * shorlander: a **tiny** win is that the text may translate to shorter strings in some locales
shorlander * but translate to twice as long in German ;)
shorlander * (i just made that up, I have no idea)

Comment 1

[Stuart Philp :sphilp]

Attachment: Screen Shot 2015-05-06 at 8.33.44 AM.png

Related to this, but not due to locale: on the en-us build there is a lot of whitespace on the 'saved to pocket' panel if you don't have a premium account that provides suggested tags (see screenshot). in general the panel should resize to fit the content i think.

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

I believe this will be fixed by bug 1161793 when the auto-resize lands.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Bryan Clark (Firefox PM) [:clarkbw] from comment #2)
> I believe this will be fixed by bug 1161793 when the auto-resize lands.

Probably not :(

The Pocket code is providing a hard-coded width and height for the panel sizes. We are not using computed sizes to scale the panel.

Comment 4

[Nate Weiner]

Just came across this bug. I'm flagging it internally, we'll aim to get a fix for this in the Tuesday drop.

Comment 5

[Justin Dolske [:Dolske]]

Bug 1163360 tweaked layout for the various locales, and the screenshots using the code we pulled for integration looked good.